-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Show resize icon on safari for document tree #3581
base: 8.3
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resize icon is visible. But for a reason i still cant resize the document tree. I dont think I'm too stupid too catch it 🤔
But maybe this is something for another PR since this was only about the icon (?)
resize-document-tree.mov
@crydotsnake can you give more details about your browser and version? |
Safari Version 16.5.1 |
Ah thx, I can reproduce the issue when the window height is quite small. I will check. This fix doesn't make sense without fixing this too. |
I could make the resize work in safari, but the Icons are still pretty small, and it is no good UX to resize the trees in Safari. In other browsers, it still works fine. |
The icon was not visible due to the background color of the tree component. Resolves: #3556
3356f39
to
0f4134a
Compare
Ok, acceptance tests now also work :) |
Will test again |
But now the whole tree incl. the topbar scrolls? That's also wrong |
So I tried a few things. The main problem is that Safari uses a higher z-index for the scrollbar of the page tree subcomponent than for the resize icon of the parent container and they overlap. I tried the trick from https://stackoverflow.com/questions/21684101/css-vertical-scrollbar-padding-left-right-in-ul-possible but that didn't work properly either. What works is to add a padding to |
Hi whats the status on this one? We found out that the autoprefixer for safari wasn't working so maybe this is related? |
What I did
Both resize icons for the left sidebar are now visible (functionality was always there only invisible)
Resolves: #3556
How I did it
Removed the background color from the tree component itself and instead set the background colours of the parent component that define the resize option.
How to verify it
Check in all browsers whether the resize icons all properly show up.